代码规范优化

ship-module-marketing/ship-module-marketing-api/src/main/java/com/yc/ship/module/marketing/enums/common/AuditStateEnum.java

@@ -21,6 +21,7 @@ public enum AuditStateEnum implements IntArrayValuable {
     public static final int[] ARRAYS = Arrays.stream(values()).mapToInt(AuditStateEnum::getType).toArray();
     private final Integer type;
     private final String name;
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-marketing/ship-module-marketing-api/src/main/java/com/yc/ship/module/marketing/enums/common/EnableStateEnum.java

@@ -17,7 +17,8 @@ public enum EnableStateEnum implements IntArrayValuable {
     private final int type;
     private final String name;
 
+    @Override
     public int[] array() {
-       return ARRAYS;
+        return ARRAYS;
     }
 }

ship-module-marketing/ship-module-marketing-api/src/main/java/com/yc/ship/module/marketing/enums/coupon/CouponCodeUseStateEnum.java

@@ -19,6 +19,7 @@ public enum CouponCodeUseStateEnum implements IntArrayValuable {
     private final int type;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-marketing/ship-module-marketing-api/src/main/java/com/yc/ship/module/marketing/enums/coupon/CouponDeliverUserGroupType.java

@@ -19,6 +19,7 @@ public enum CouponDeliverUserGroupType implements IntArrayValuable {
     private final int type;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-marketing/ship-module-marketing-api/src/main/java/com/yc/ship/module/marketing/enums/coupon/CouponProductTypeEnum.java

@@ -19,6 +19,7 @@ public enum CouponProductTypeEnum implements IntArrayValuable {
     private final Integer type;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-marketing/ship-module-marketing-biz/src/main/java/com/yc/ship/module/marketing/api/coupon/CouponApiImpl.java

@@ -58,7 +58,7 @@ public class CouponApiImpl  implements CouponApi{
         if(couponDO == null) {
             throw exception(COUPON_NOT_EXISTS);
         }
-        if(couponDO.getAuditState() != CouponAuditStateEnum.AUDIT_PASS.getType()) {
+        if(!couponDO.getAuditState().equals(CouponAuditStateEnum.AUDIT_PASS.getType())) {
             throw exception(COUPON_NOT_AUDIT_PASS);
         }
         if(couponDO.getState() != EnableStateEnum.ENABLE.getType()) {
@@ -113,7 +113,7 @@ public class CouponApiImpl  implements CouponApi{
         //3.判断是否使用后继续发券
         CouponDO coupon = couponService.getCoupon(couponId);
         Integer useAfter = coupon.getUseAfter();
-        if(useAfter == YesOrNoEnum.YES.getType()) {
+        if(useAfter.equals(YesOrNoEnum.YES.getType())) {
             couponService.receiveCoupon(reqDto.getMemberId(), couponId);
         }
         return CommonResult.success(true);
@@ -173,10 +173,10 @@ public class CouponApiImpl  implements CouponApi{
             CouponCodeDO couponCodeDO = couponCodeMapper.selectById(couponCodeUseRecordDO.getCouponCodeId());
             Long couponId = couponCodeDO.getCouponId();
             CouponDO coupon = couponService.getCoupon(couponId);
-            if(coupon.getUseAfter() == YesOrNoEnum.NO.getType()) {
+            if(coupon.getUseAfter().equals(YesOrNoEnum.NO.getType())) {
                 //如果是不继续发券，则直接修改为未使用
                 couponCodeMapper.updateById(couponCodeDO.setState(CouponCodeUseStateEnum.UNUSED.getType()));
-            }else if(coupon.getUseAfter() == YesOrNoEnum.YES.getType()) {
+            }else if(coupon.getUseAfter().equals(YesOrNoEnum.YES.getType())) {
                 //是继续发券，则直接删除券码
                 couponCodeMapper.deleteById(couponCodeDO.getId());
             }

ship-module-marketing/ship-module-marketing-biz/src/main/java/com/yc/ship/module/marketing/service/coupon/CouponServiceImpl.java

@@ -192,10 +192,10 @@ public class CouponServiceImpl implements CouponService {
 
         }
 
-        if (CouponAuditStateEnum.AUDIT_PASS.getType() != couponDO.getAuditState()) {
+        if (!CouponAuditStateEnum.AUDIT_PASS.getType().equals(couponDO.getAuditState())) {
             throw exception(COUPON_NOT_AUDIT_PASS);
         }
-        if(CommonStatusEnum.ENABLE.getStatus() != couponDO.getState()) {
+        if(!CommonStatusEnum.ENABLE.getStatus().equals(couponDO.getState())) {
             throw exception(COUPON_NOT_ENABLE);
         }
         //2.检查派发规则
@@ -272,14 +272,14 @@ public class CouponServiceImpl implements CouponService {
             Boolean flag = basic.compareTo(reqVo.getOrderAmount()) <= 0;
             //满足门槛金额
             if (flag) {
-                if (couponDO.getRelationType() == CouponProductTypeEnum.ALL.getType()) {
+                if (couponDO.getRelationType().equals(CouponProductTypeEnum.ALL.getType())) {
                     return true;
-                } else if (couponDO.getRelationType() == CouponProductTypeEnum.CATEGORY.getType()) {
+                } else if (couponDO.getRelationType().equals(CouponProductTypeEnum.CATEGORY.getType())) {
                     if(finalType == null) {
                         return false;
                     }
                     return finalType.equals(couponDO.getRelationId());
-                } else if (couponDO.getRelationType() == CouponProductTypeEnum.CUSTOM.getType()) {
+                } else if (couponDO.getRelationType().equals(CouponProductTypeEnum.CUSTOM.getType())) {
                     boolean flag1 = couponDO.getRelationChildId().equals(reqVo.getSpuId());
                     if (flag1) {
                         List<String> list1 = Arrays.asList(couponDO.getRelationSkuId().split(","));
@@ -342,15 +342,15 @@ public class CouponServiceImpl implements CouponService {
             List<CouponProductDo> couponProductDoList = longListMap.get(couponDO.getId());
             List<CouponProductDo> filterList = couponProductDoList.stream().filter(couponProductDo -> {
                 Integer relationType = couponProductDo.getType();
-                if (relationType == CouponProductTypeEnum.ALL.getType()) {
+                if (relationType.equals(CouponProductTypeEnum.ALL.getType())) {
                     return true;
-                } else if (relationType == CouponProductTypeEnum.CATEGORY.getType()) {
+                } else if (relationType.equals(CouponProductTypeEnum.CATEGORY.getType())) {
                     if(finalType == null) {
                         return false;
                     }
-                    return finalType.equals(couponProductDo.getRelationId()) || finalType == couponProductDo.getRelationId();
-                } else if (relationType == CouponProductTypeEnum.CUSTOM.getType()) {
-                    return couponProductDo.getRelationChildId().equals(spuId) || couponProductDo.getRelationChildId() == spuId;
+                    return finalType.equals(couponProductDo.getRelationId()) || finalType.equals(couponProductDo.getRelationId());
+                } else if (relationType.equals(CouponProductTypeEnum.CUSTOM.getType())) {
+                    return couponProductDo.getRelationChildId().equals(spuId) || couponProductDo.getRelationChildId().equals(spuId);
                 }
                 return false;
             }).collect(Collectors.toList());

ship-module-marketing/ship-module-marketing-biz/src/main/java/com/yc/ship/module/marketing/service/couponProduct/CouponProductServiceImpl.java

@@ -53,10 +53,10 @@ public class CouponProductServiceImpl implements CouponProductService {
         //删除之前的记录
         couponProductMapper.deleteByCouponId(couponId);
         //再新增现在的
-        if(CouponProductTypeEnum.ALL.getType() == type) {
+        if(CouponProductTypeEnum.ALL.getType().equals(type)) {
             CouponProductDo couponProductDo = BeanUtils.toBean(reqVO, CouponProductDo.class);
             couponProductMapper.insert(couponProductDo);
-        }else if(CouponProductTypeEnum.CATEGORY.getType() == type){
+        }else if(CouponProductTypeEnum.CATEGORY.getType().equals(type)){
             List<Long> relationIds = reqVO.getRelationIds();
             List<CouponProductDo> list = new ArrayList<>();
             relationIds.stream().forEach(relationId -> {
@@ -67,7 +67,7 @@ public class CouponProductServiceImpl implements CouponProductService {
                 list.add(couponProductDo);
             });
             couponProductMapper.insertBatch(list);
-        }else if(CouponProductTypeEnum.CUSTOM.getType() == type){
+        }else if(CouponProductTypeEnum.CUSTOM.getType().equals(type)){
             List<RelationReqVo> relationList = reqVO.getRelationList();
             List<CouponProductDo> list = new ArrayList<>();
             relationList.stream().forEach(relation -> {
@@ -93,10 +93,10 @@ public class CouponProductServiceImpl implements CouponProductService {
             CouponProductDo couponProductDo = list.get(0);
             vo.setCouponId(couponProductDo.getCouponId());
             vo.setType(couponProductDo.getType());
-            if(CouponProductTypeEnum.CATEGORY.getType() == couponProductDo.getType()) {
+            if(CouponProductTypeEnum.CATEGORY.getType().equals(couponProductDo.getType())) {
                 List<Long> relationIds = CollectionUtils.convertList(list, CouponProductDo::getRelationId);
                 vo.setRelationIds(relationIds);
-            }else if(CouponProductTypeEnum.CUSTOM.getType() == couponProductDo.getType()) {
+            }else if(CouponProductTypeEnum.CUSTOM.getType().equals(couponProductDo.getType())) {
                 List<RelationRespVo> relationList = couponProductMapper.selectRelationProductList(couponId);
                 relationList.stream().forEach(item -> item.setRelationSkuIds(Arrays.asList(item.getRelationSkuIdsStr().split(","))));
                 vo.setRelationList(relationList);

ship-module-ota/ship-module-ota-api/src/main/java/com/yc/ship/module/ota/enums/AuditStatusEnum.java

@@ -17,6 +17,7 @@ public enum AuditStatusEnum implements IntArrayValuable {
     private final Integer value;
     public static final int[] ARRAYS = Arrays.stream(values()).mapToInt(AuditStatusEnum::getValue).toArray();
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-ota/ship-module-ota-biz/src/main/java/com/yc/ship/module/ota/service/distributorselfrecharge/DistributorSelfRechargeServiceImpl.java

@@ -21,7 +21,6 @@ import javax.annotation.Resource;
 import java.util.concurrent.atomic.AtomicReference;
 
 import static com.yc.ship.framework.common.exception.util.ServiceExceptionUtil.exception0;
-import static com.yc.ship.framework.security.core.util.SecurityFrameworkUtils.getLoginUserId;
 
 
 /**
@@ -46,8 +45,8 @@ public class DistributorSelfRechargeServiceImpl implements DistributorSelfRechar
 
 
 
+    @Override
     public DistributorSelfRechargeSimpleRespVO createDistributorSelfRecharge(DistributorSelfRechargeSaveReqVO createReqVO) {
-        long loginUserId = getLoginUserId();
         LoginTypeRespVO loginType = distributorService.getLoginType();
 
         if (loginType.getType() == 3) {
@@ -57,7 +56,6 @@ public class DistributorSelfRechargeServiceImpl implements DistributorSelfRechar
         // 插入
         DistributorSelfRechargeDO distributorSelfRecharge = BeanUtils.toBean(createReqVO, DistributorSelfRechargeDO.class);
         Long id = IdWorker.getId(distributorSelfRecharge);
-        String rechargeNo = "CZ" + id;
         distributorSelfRecharge.setId(id);
         distributorSelfRecharge.setDistributorId(loginType.getDistributorId());
         distributorSelfRecharge.setRechargeState(0);

ship-module-product/ship-module-product-api/src/main/java/com/yc/ship/module/product/enums/DistributorOrStoreEnum.java

@@ -17,6 +17,7 @@ public enum DistributorOrStoreEnum implements IntArrayValuable {
     private final Integer value;
     public static final int[] ARRAYS = Arrays.stream(values()).mapToInt(DistributorOrStoreEnum::getValue).toArray();
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-product/ship-module-product-biz/src/main/java/com/yc/ship/module/product/service/voyagestockdistribute/VoyageStockDistributeNewServiceImpl.java

@@ -177,9 +177,9 @@ public class VoyageStockDistributeNewServiceImpl implements VoyageStockDistribut
         //TODO:此处当前默认为1分销商，暂无门店
         type = DistributorOrStoreEnum.DISTRIBUTOR.getValue();
         List<VoyageStockDistributeRoomDO> roomList;
-        if(type == DistributorOrStoreEnum.DISTRIBUTOR.getValue()) {
+        if(type.equals(DistributorOrStoreEnum.DISTRIBUTOR.getValue())) {
             roomList = voyageStockDistributeRoomService.getRoomListByRoomModelIdAndFloor(reqVO.getDistributorId(), reqVO.getRoomModelIdFloorList());
-        }else if(type == DistributorOrStoreEnum.STORE.getValue()) {
+        }else if(type.equals(DistributorOrStoreEnum.STORE.getValue())) {
             roomList = voyageStockDistributeRoomService.getRoomListByRoomModelIdAndFloor(reqVO.getStoreId(), reqVO.getRoomModelIdFloorList());
         }else {
             roomList = new ArrayList<>();

ship-module-resource/ship-module-resource-api/src/main/java/com/yc/ship/module/resource/enums/CarStatusEnum.java

@@ -18,6 +18,7 @@ public enum CarStatusEnum implements IntArrayValuable {
     private final Integer status;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-resource/ship-module-resource-api/src/main/java/com/yc/ship/module/resource/enums/DeleteStatusEnum.java

@@ -12,6 +12,7 @@ public enum DeleteStatusEnum implements IntArrayValuable {
     private final Integer status;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-resource/ship-module-resource-api/src/main/java/com/yc/ship/module/resource/enums/guide/GuideRefundStatusEnum.java

@@ -31,6 +31,7 @@ public enum GuideRefundStatusEnum implements IntArrayValuable {
     private final Integer status;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-resource/ship-module-resource-api/src/main/java/com/yc/ship/module/resource/enums/guide/GuideTaskPrintStatusEnum.java

@@ -14,6 +14,7 @@ public enum GuideTaskPrintStatusEnum implements IntArrayValuable {
     private final Integer status;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-resource/ship-module-resource-api/src/main/java/com/yc/ship/module/resource/enums/guide/GuideTypeEnum.java

@@ -16,6 +16,7 @@ public enum GuideTypeEnum implements IntArrayValuable {
     private final Integer status;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-resource/ship-module-resource-api/src/main/java/com/yc/ship/module/resource/enums/guide/GuideUseNeedStatusEnum.java

@@ -18,6 +18,7 @@ public enum GuideUseNeedStatusEnum implements IntArrayValuable {
     private final Integer status;
     private final String name;
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-resource/ship-module-resource-biz/src/main/java/com/yc/ship/module/resource/helper/RoomNumberHelper.java

@@ -49,7 +49,9 @@ public class RoomNumberHelper {
      */
     private static String formatNumber(long number, int length) {
         String numStr = String.valueOf(number); 
-        if (numStr.length()  >= length) return numStr;
+        if (numStr.length()  >= length) {
+            return numStr;
+        }
         
         StringBuilder sb = new StringBuilder();
         for (int i = 0; i < length - numStr.length();  i++) {

ship-module-resource/ship-module-resource-biz/src/main/java/com/yc/ship/module/resource/service/car/CarServiceImpl.java

@@ -124,6 +124,7 @@ public class CarServiceImpl implements CarService {
     }
 
 
+    @Override
     public List<CarDO> getCarList() {
         return this.getCarList(new CarReqVO());
     }
@@ -136,6 +137,7 @@ public class CarServiceImpl implements CarService {
     }
 
 
+    @Override
     public List<CarTypeNumRespVO> getstatiscisCarTypeNum(){
         return carMapper.getstatiscisCarTypeNum();
     };

ship-module-resource/ship-module-resource-biz/src/main/java/com/yc/ship/module/resource/service/driver/DriverServiceImpl.java

@@ -45,7 +45,7 @@ public class DriverServiceImpl implements DriverService {
         // 创建系统用户
         AdminUserRespDTO adminDto = new AdminUserRespDTO();
         adminDto.setNickname(createReqVO.getName());
-        adminDto.setUsername(PinyinUtil.getPinyin(createReqVO.getName(),""));
+        adminDto.setUsername(PinyinUtil.getPinyin(createReqVO.getName(), ""));
         adminDto.setMobile(createReqVO.getPhone());
         adminDto.setPassword(createReqVO.getPhone());
         adminDto.setSex(createReqVO.getSex());
@@ -57,7 +57,7 @@ public class DriverServiceImpl implements DriverService {
             driver.setDeleted(false);
             driverMapper.insert(driver);
             return driver.getId();
-        }else{
+        } else {
             throw exception(ErrorCodeConstants.DRIVER_CREATE_FAILED);
         }
     }
@@ -100,13 +100,14 @@ public class DriverServiceImpl implements DriverService {
         return driverMapper.selectPage(pageReqVO);
     }
 
+    @Override
     public List<DriverDO> getDriverList() {
         return this.getDriverList(new DriverSimpleRespVO());
     }
 
     @Override
     public List<DriverDO> getDriverList(DriverSimpleRespVO respVO) {
-        if(null == respVO.getUseStatus()){
+        if (null == respVO.getUseStatus()) {
             respVO.setUseStatus(UseStatusEnum.ENABLE.getStatus());
         }
         List<DriverDO> list = driverMapper.selectList(respVO);
@@ -119,6 +120,7 @@ public class DriverServiceImpl implements DriverService {
         return driverMapper.selectSimpleList();
     }
 
+    @Override
     public List<DriverRespVO> getDriverDefaultCarList(DriverReqVO reqVO) {
         reqVO.setTenantId(String.valueOf(TenantContextHolder.getTenantId()));
         return driverMapper.getDriverDefaultCarList(reqVO);

ship-module-resource/ship-module-resource-biz/src/main/java/com/yc/ship/module/resource/service/resource/util/EncryptUtils.java

@@ -17,12 +17,16 @@ public  class EncryptUtils {
 
     // Base64 ------------------
     public static String base64Enc(String src) {
-        if (src == null || src.length() == 0 || src.trim().length() == 0) return "";
+        if (src == null || src.length() == 0 || src.trim().length() == 0) {
+            return "";
+        }
         return new String(base64Enc(src.getBytes()));
     }
 
     public static String base64Dec(String src) {
-        if (src == null || src.length() == 0 || src.trim().length() == 0) return "";
+        if (src == null || src.length() == 0 || src.trim().length() == 0) {
+            return "";
+        }
         return new String(base64Dec(src.getBytes()));
     }
     public static byte[] base64Enc(byte[] bytes) {

ship-module-trade/ship-module-trade-api/src/main/java/com/yc/ship/module/trade/enums/ContractStatusEnum.java

@@ -20,6 +20,7 @@ public enum ContractStatusEnum implements IntArrayValuable {
     private final Integer value;
     public static final int[] ARRAYS = Arrays.stream(values()).mapToInt(ContractStatusEnum::getValue).toArray();
 
+    @Override
     public int[] array() {
         return ARRAYS;
     }

ship-module-trade/ship-module-trade-api/src/main/java/com/yc/ship/module/trade/enums/InsuranceStatusEnum.java

@@ -1,7 +1,6 @@
 package com.yc.ship.module.trade.enums;
 
 import com.yc.ship.framework.common.core.ArrayValuable;
-import com.yc.ship.framework.common.core.IntArrayValuable;
 import lombok.Getter;
 
 import java.util.Arrays;
@@ -19,6 +18,7 @@ public enum InsuranceStatusEnum implements ArrayValuable<Integer> {
     private final Integer value;
     public static final Integer[] ARRAYS = Arrays.stream(values()).map(InsuranceStatusEnum::getValue).toArray(Integer[]::new);
 
+    @Override
     public Integer[] array() {
         return ARRAYS;
     }

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/controller/admin/order/AdminTradeOrderController.java

@@ -50,18 +50,18 @@ public class AdminTradeOrderController {
     public CommonResult<List<TradeOrderLogRespVO>> getOrderLogListByOrderId(Long orderId) {
         List<TradeOrderLogDO> list = tradeOrderLogService.getOrderLogListByOrderId(orderId);
         List<TradeOrderLogRespVO> tradeOrderLogRespVOS = BeanUtils.toBean(list, TradeOrderLogRespVO.class);
-        List<Long> userIds = CollectionUtils.convertList(tradeOrderLogRespVOS, TradeOrderLogRespVO::getUserId, (item) -> item.getUserType() == UserTypeEnum.ADMIN.getValue());
+        List<Long> userIds = CollectionUtils.convertList(tradeOrderLogRespVOS, TradeOrderLogRespVO::getUserId, (item) -> item.getUserType().equals(UserTypeEnum.ADMIN.getValue()));
         List<AdminUserRespDTO> userList = adminUserApi.getUserList(userIds);
         Map<Long, AdminUserRespDTO> userMap = CollectionUtils.convertMap(userList, AdminUserRespDTO::getId);
 
-        List<Long> memberIds = CollectionUtils.convertList(tradeOrderLogRespVOS, TradeOrderLogRespVO::getUserId, (item) -> item.getUserType() == UserTypeEnum.MEMBER.getValue());
+        List<Long> memberIds = CollectionUtils.convertList(tradeOrderLogRespVOS, TradeOrderLogRespVO::getUserId, (item) -> item.getUserType().equals(UserTypeEnum.MEMBER.getValue()));
         List<MemberUserRespDTO> memberList = memberUserApi.getUserList(memberIds);
         Map<Long, MemberUserRespDTO> memberMap = CollectionUtils.convertMap(memberList, MemberUserRespDTO::getId);
 
         tradeOrderLogRespVOS.stream().forEach(item -> {
-            if(item.getUserType() == UserTypeEnum.ADMIN.getValue()) {
+            if(item.getUserType().equals(UserTypeEnum.ADMIN.getValue())) {
                 MapUtils.findAndThen(userMap, item.getUserId(), user -> item.setUserName(user.getNickname()));
-            }else if(item.getUserType() == UserTypeEnum.MEMBER.getValue()) {
+            }else if(item.getUserType().equals(UserTypeEnum.MEMBER.getValue())) {
                 MapUtils.findAndThen(memberMap, item.getUserId(), member -> item.setUserName(member.getNickname()));
             }
         });

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/framework/common/EncryptUtils.java

@@ -17,12 +17,16 @@ public  class EncryptUtils {
 
     // Base64 ------------------
     public static String base64Enc(String src) {
-        if (src == null || src.length() == 0 || src.trim().length() == 0) return "";
+        if (src == null || src.length() == 0 || src.trim().length() == 0) {
+            return "";
+        }
         return new String(base64Enc(src.getBytes()));
     }
 
     public static String base64Dec(String src) {
-        if (src == null || src.length() == 0 || src.trim().length() == 0) return "";
+        if (src == null || src.length() == 0 || src.trim().length() == 0) {
+            return "";
+        }
         return new String(base64Dec(src.getBytes()));
     }
     public static byte[] base64Enc(byte[] bytes) {

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/framework/common/HexUtil.java

@@ -164,8 +164,9 @@ public class HexUtil {
     }
 
     public static byte[] parseHexStr2Byte(String hexStr) {
-        if (hexStr.length() < 1)
+        if (hexStr.length() < 1) {
             return null;
+        }
         byte[] result = new byte[hexStr.length() / 2];
         for (int i = 0; i < hexStr.length() / 2; i++) {
             int high = Integer.parseInt(hexStr.substring(i * 2, i * 2 + 1), 16);

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/service/ota/impl/MeiTuanServiceImpl.java

@@ -722,13 +722,13 @@ public class MeiTuanServiceImpl implements MeiTuanService, OtaService {
                         refundId, -1);
             }
             // 订单不存在或订单无效时 同意退款
-            if (order == null || order.getOrderStatus() == TradeOrderStatusEnum.CANCELED.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.FAIL.getStatus()) {
+            if (order == null || order.getOrderStatus().equals(TradeOrderStatusEnum.CANCELED.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.FAIL.getStatus())) {
                 return meituanReturn("200", "无效订单", distributor.getOtaAccount(), orderNo, otaOrderId,
                         refundId, -1);
-            } else if (order.getOrderStatus() == TradeOrderStatusEnum.INIT.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.UNPAID.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.PAYING.getStatus()) {
+            } else if (order.getOrderStatus().equals(TradeOrderStatusEnum.INIT.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.UNPAID.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.PAYING.getStatus())) {
                 CommonResult<?> commonResult = tradeOrderPayService.cancelOrder(order.getId());
                 if (commonResult.isSuccess()) {
                     return meituanReturn("200", "退款成功", distributor.getOtaAccount(), orderNo, otaOrderId, refundId, -1);

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/service/ota/impl/TiktokCalendarServiceImpl.java

@@ -1528,11 +1528,11 @@ public class TiktokCalendarServiceImpl implements TiktokCalendarService, OtaServ
             // 订单信息
             TradeOrderDO order = tradeOrderRepositoryService.getOrderByOtaAndExternalOrderNo(orderId, distributor.getId().toString());
             // 订单不存在或已过期时 订单未出票成功
-            if (order == null || order.getOrderStatus() == TradeOrderStatusEnum.CANCELED.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.FAIL.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.CANCELED.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.PROCESS_FAIL.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.EXPIRED.getStatus()) {
+            if (order == null || order.getOrderStatus().equals(TradeOrderStatusEnum.CANCELED.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.FAIL.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.CANCELED.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.PROCESS_FAIL.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.EXPIRED.getStatus())) {
                 return returnSendVouchersFailed();
             }
             JSONObject ticketRule = body.getJSONObject("ticket_rule");
@@ -1860,12 +1860,12 @@ public class TiktokCalendarServiceImpl implements TiktokCalendarService, OtaServ
             // 订单信息
             TradeOrderDO order = tradeOrderRepositoryService.getOrderByOtaAndExternalOrderNo(orderId, distributor.getId().toString());
             // 订单不存在或订单无效时 同意退款
-            if (order == null || order.getOrderStatus() == TradeOrderStatusEnum.CANCELED.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.FAIL.getStatus()) {
+            if (order == null || order.getOrderStatus().equals(TradeOrderStatusEnum.CANCELED.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.FAIL.getStatus())) {
                 return returnCancelTiktokCalendar(0, "无效订单");
-            }else if (order.getOrderStatus() == TradeOrderStatusEnum.INIT.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.UNPAID.getStatus()
-                    || order.getOrderStatus() == TradeOrderStatusEnum.PAYING.getStatus()) {
+            }else if (order.getOrderStatus().equals(TradeOrderStatusEnum.INIT.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.UNPAID.getStatus())
+                    || order.getOrderStatus().equals(TradeOrderStatusEnum.PAYING.getStatus())) {
                 CommonResult<?> commonResult = tradeOrderPayService.cancelOrder(order.getId());
                 if (commonResult.isSuccess()) {
                     return returnCancelTiktokCalendar(0, "退款成功");

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/service/ota/impl/XieChengServiceImpl.java

@@ -815,7 +815,7 @@ public class XieChengServiceImpl implements XieChengService, OtaService {
                     CommonResult<TradeRefundRespDTO> refundResult = tradeRefundService.refund(refundCreateReqDTO);
                     if (refundResult.isSuccess()) {
                         res_body.put("supplierConfirmType", 1);
-                    } else if (refundResult.getCode() == REFUND_AUDITING.getCode()) {
+                    } else if (refundResult.getCode().equals(REFUND_AUDITING.getCode())) {
                         // 1.取消已确认 2.取消待确认（当confirmType =2时需异步返回确认结果的）
                         res_body.put("supplierConfirmType", 2);
                     }else {
@@ -990,15 +990,15 @@ public class XieChengServiceImpl implements XieChengService, OtaService {
                     voucher.put("voucherId", tradeDetailDO.getVoucherCode());
 
                     // 0、待使用；1、已使用；2、已取消
-                    if (tradeDetailDO.getVoucherStatus() == VoucherStatusEnum.UNUSED.getStatus() || tradeDetailDO.getVoucherStatus() == VoucherStatusEnum.TOOK.getStatus()) {
+                    if (tradeDetailDO.getVoucherStatus().equals(VoucherStatusEnum.UNUSED.getStatus()) || tradeDetailDO.getVoucherStatus().equals(VoucherStatusEnum.TOOK.getStatus())) {
                         passenger.put("passengerStatus", 0);
                         voucher.put("voucherStatus", 0);
-                    } else if (tradeDetailDO.getVoucherStatus() == VoucherStatusEnum.VERIFIED.getStatus() || tradeDetailDO.getVoucherStatus() == VoucherStatusEnum.OVERDUE_VERIFIED.getStatus()) {
+                    } else if (tradeDetailDO.getVoucherStatus().equals(VoucherStatusEnum.VERIFIED.getStatus()) || tradeDetailDO.getVoucherStatus().equals(VoucherStatusEnum.OVERDUE_VERIFIED.getStatus())) {
                         passenger.put("passengerStatus", 1);
                         voucher.put("voucherStatus", 1);
-                    } else if (tradeDetailDO.getVoucherStatus() == VoucherStatusEnum.REFUNDING.getStatus()
+                    } else if (tradeDetailDO.getVoucherStatus().equals(VoucherStatusEnum.REFUNDING.getStatus())
                             || ObjectUtil.equals(tradeDetailDO.getVoucherStatus(),VoucherStatusEnum.PART_REFUND.getStatus())
-                            || tradeDetailDO.getVoucherStatus() == VoucherStatusEnum.REFUND.getStatus()) {
+                            || tradeDetailDO.getVoucherStatus().equals(VoucherStatusEnum.REFUND.getStatus())) {
                         passenger.put("passengerStatus", 2);
                         voucher.put("voucherStatus", 2);
                     }

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/utils/HexUtil.java

@@ -165,8 +165,9 @@ public class HexUtil {
     }
 
     public static byte[] parseHexStr2Byte(String hexStr) {
-        if (hexStr.length() < 1)
+        if (hexStr.length() < 1) {
             return null;
+        }
         byte[] result = new byte[hexStr.length() / 2];
         for (int i = 0; i < hexStr.length() / 2; i++) {
             int high = Integer.parseInt(hexStr.substring(i * 2, i * 2 + 1), 16);