代码优化

ship-module-ota/ship-module-ota-api/src/main/java/com/yc/ship/module/ota/api/OtaDistributorApi.java

@@ -2,23 +2,25 @@ package com.yc.ship.module.ota.api;
 
 import com.yc.ship.framework.common.pojo.CommonResult;
 import com.yc.ship.module.ota.api.dto.*;
-import io.swagger.v3.oas.annotations.parameters.RequestBody;
+import io.swagger.v3.oas.annotations.tags.Tag;
 
-import javax.validation.Valid;
-import java.util.Collection;
 import java.util.List;
 
+@Tag(name = "API 服务 - 订单")
 public interface OtaDistributorApi {
     /**
      * 根据登录用户id获取分销商信息
+     *
      * @param loginUserId
      * @return
      */
     DistributorRespDTO getDistributorByLoginUserId(Long loginUserId);
+
     DistributorRespDTO getDistributorById(Long id);
 
     /**
      * 分销商交易充值
+     *
      * @param rechargeReqDTO
      * @return
      */
@@ -47,8 +49,9 @@ public interface OtaDistributorApi {
 
     /**
      * 根据经销商类型获取分销商列表
+     *
      * @param type
      * @return
      */
-    List<DistributorRespDTO> getDistributorList(Integer  type);
+    List<DistributorRespDTO> getDistributorList(Integer type);
 }

ship-module-ota/ship-module-ota-biz/src/main/java/com/yc/ship/module/ota/api/OtaDistributorApiImpl.java

@@ -5,7 +5,6 @@ import com.yc.ship.framework.common.util.object.BeanUtils;
 import com.yc.ship.framework.tenant.core.aop.TenantIgnore;
 import com.yc.ship.module.ota.api.dto.*;
 import com.yc.ship.module.ota.dal.dataobject.distributor.DistributorDO;
-import com.yc.ship.module.ota.dal.mysql.distributor.DistributorMapper;
 import com.yc.ship.module.ota.service.distributor.DistributorService;
 import com.yc.ship.module.ota.service.distributorproduct.DistributorProductService;
 import com.yc.ship.module.ota.service.distributorrecharge.DistributorRechargeService;
@@ -15,7 +14,6 @@ import org.springframework.stereotype.Service;
 import javax.annotation.Resource;
 import java.util.List;
 
-import static com.yc.ship.framework.common.pojo.CommonResult.error;
 import static com.yc.ship.framework.common.pojo.CommonResult.success;
 
 @Service
@@ -24,8 +22,6 @@ public class OtaDistributorApiImpl implements OtaDistributorApi{
     @Resource
     private DistributorService distributorService;
 
-    @Resource
-    private DistributorMapper distributorMapper;
     @Resource
     private DistributorProductService distributorProductService;
 
@@ -93,13 +89,7 @@ public class OtaDistributorApiImpl implements OtaDistributorApi{
     @Override
     @TenantIgnore
     public CommonResult<DistributorRespDTO> getDistributorByAccountTenantId(Long accountTenantId) {
-        List<DistributorDO> distributor = distributorMapper.selectList(DistributorDO::getAccountTenantId, accountTenantId);
-        if(distributor!=null && distributor.size()>0){
-            return success(BeanUtils.toBean(distributor.get(0), DistributorRespDTO.class));
-        }else{
-            return error(500,"未查询到分销商信息");
-        }
-
+        return  distributorService.getDistributorByAccountTenantId(accountTenantId);
     }
     @Override
     public CommonResult<?> distributorSelfRecharge(DistributorSelfRechargeReqDTO payNotifyReqDTO) {
@@ -114,7 +104,7 @@ public class OtaDistributorApiImpl implements OtaDistributorApi{
 
     @Override
     public List<DistributorRespDTO> getDistributorList(Integer type) {
-        return BeanUtils.toBean(distributorMapper.selectListByType(type), DistributorRespDTO.class);
+        return BeanUtils.toBean(distributorService.selectListByType(type), DistributorRespDTO.class);
     }
 
 }

ship-module-ota/ship-module-ota-biz/src/main/java/com/yc/ship/module/ota/controller/admin/distributorproduct/DistributorProductController.java

@@ -15,6 +15,7 @@ import com.yc.ship.module.ota.controller.admin.distributorproduct.vo.product.Pro
 import com.yc.ship.module.ota.dal.dataobject.distributorproduct.DistributorAgencyPriceDO;
 import com.yc.ship.module.ota.dal.dataobject.distributorproduct.DistributorProductDO;
 import com.yc.ship.module.ota.dal.mysql.distributor.DistributorMapper;
+import com.yc.ship.module.ota.service.distributor.DistributorService;
 import com.yc.ship.module.ota.service.distributorproduct.DistributorProductService;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.Parameter;
@@ -40,7 +41,7 @@ public class DistributorProductController {
     private DistributorProductService distributorProductService;
 
     @Resource
-    private DistributorMapper distributorMapper;
+    private DistributorService distributorService;
 
     @PostMapping("/create")
     @Operation(summary = "创建平台产品与分销商关系")
@@ -89,7 +90,7 @@ public class DistributorProductController {
     public CommonResult<PageResult<DistributorProductRespVO>> pageDistributorProduct(@Valid DistributorProductPageReqVO pageReqVO) {
         ProductPageReqVO vo = new ProductPageReqVO();
         //查询分销商信息
-        DistributorRespVO DistributorVo = distributorMapper.getDistributorById(pageReqVO.getDistributorId());
+        DistributorRespVO DistributorVo = distributorService.getADistributorById(pageReqVO.getDistributorId());
         if(DistributorVo != null){
             vo.setChannelType(DistributorVo.getType());
             vo.setDistributorId(DistributorVo.getId());
@@ -105,7 +106,7 @@ public class DistributorProductController {
     @Operation(summary = "获得产品树及分销商分销产品")
     public CommonResult<List<DistributorProductRespVO>> distributorProductTree(@Valid ProductPageReqVO pageReqVO) {
         //查询分销商信息
-        DistributorRespVO DistributorVo = distributorMapper.getDistributorById(pageReqVO.getDistributorId());
+        DistributorRespVO DistributorVo = distributorService.getADistributorById(pageReqVO.getDistributorId());
         if(DistributorVo != null){
             pageReqVO.setChannelType(DistributorVo.getType());
             pageReqVO.setDistributorId(DistributorVo.getId());

ship-module-ota/ship-module-ota-biz/src/main/java/com/yc/ship/module/ota/service/distributor/DistributorService.java

@@ -90,6 +90,9 @@ public interface DistributorService {
     CommonResult<DistributorRespDTO> getDistributorByAccountTenantId(Long accountTenantId);
 
     List<DistributorRespVO> getOtcDistributor(Integer type);
+
+    List<DistributorDO> selectListByType(Integer type);
+
     List<DistributorRespVO> getOtcDistributor(Integer type, Long productId);
 
     /**
@@ -105,8 +108,7 @@ public interface DistributorService {
 
     CommonResult<DistributorRespDTO> getDistributorByOtaAccount(String otaAccount, String typeCode);
 
-    @TenantIgnore
-    DistributorDO getDistributorById(Long distributorId);
+    DistributorDO getDistributorById(Long id);
 
     DistributorDO getDistributorByLoginUser(String loginName);
 
@@ -128,4 +130,5 @@ public interface DistributorService {
      */
     DistributorDO getDistributorByLoginUserId(Long loginUserId);
 
+    DistributorRespVO getADistributorById(Long id);
 }

ship-module-otc/ship-module-otc-biz/src/main/java/com/yc/ship/module/otc/controller/admin/otclevel/OtcLevelController.java

@@ -77,6 +77,13 @@ public class OtcLevelController {
         return success(BeanUtils.toBean(level, OtcLevelRespVO.class));
     }
 
+    @GetMapping("/getLevelByTravlId")
+    @Operation(summary = "获得旅行社等级")
+    public CommonResult<OtcLevelRespVO> getLevelByTravlId(@RequestParam("travlId") Long travlId) {
+        OtcLevelDO level = levelService.getLevelByTravlId(travlId);
+        return success(BeanUtils.toBean(level, OtcLevelRespVO.class));
+    }
+
     @GetMapping("/page")
     @Operation(summary = "获得旅行社等级管理分页")
     @PreAuthorize("@ss.hasPermission('otc:level:query')")

ship-module-otc/ship-module-otc-biz/src/main/java/com/yc/ship/module/otc/service/otclevel/OtcLevelService.java

@@ -45,6 +45,8 @@ public interface OtcLevelService {
      */
     OtcLevelDO getLevel(Long id);
 
+    OtcLevelDO getLevelByTravlId(Long trvlId);
+
     /**
      * 获得旅行社等级管理分页
      *

ship-module-otc/ship-module-otc-biz/src/main/java/com/yc/ship/module/otc/service/otclevel/OtcLevelServiceImpl.java

@@ -3,6 +3,7 @@ package com.yc.ship.module.otc.service.otclevel;
 import com.baomidou.mybatisplus.core.toolkit.IdWorker;
 import com.yc.ship.framework.common.pojo.PageResult;
 import com.yc.ship.framework.common.util.object.BeanUtils;
+import com.yc.ship.framework.mybatis.core.query.LambdaQueryWrapperX;
 import com.yc.ship.module.otc.controller.admin.otclevel.vo.OtcLevelPageReqVO;
 import com.yc.ship.module.otc.controller.admin.otclevel.vo.OtcLevelSaveReqVO;
 import com.yc.ship.module.otc.dal.dataobject.otclevel.OtcLevelDO;
@@ -69,6 +70,15 @@ public class OtcLevelServiceImpl implements OtcLevelService {
         return levelMapper.selectById(id);
     }
 
+    @Override
+    public OtcLevelDO getLevelByTravlId(Long id) {
+        List<OtcLevelDO> levelList = levelMapper.selectList(new LambdaQueryWrapperX<OtcLevelDO>().eq(OtcLevelDO::getId, id));
+        if(levelList!=null && !levelList.isEmpty()){
+            return levelList.get(0);
+        }
+        return null;
+    }
+
     @Override
     public PageResult<OtcLevelDO> getLevelPage(OtcLevelPageReqVO pageReqVO) {
         return levelMapper.selectPage(pageReqVO);

ship-module-product/ship-module-product-biz/src/main/java/com/yc/ship/module/product/service/distributorDiscount/DistributorDiscountServiceImpl.java

@@ -3,6 +3,8 @@ package com.yc.ship.module.product.service.distributorDiscount;
 import com.baomidou.mybatisplus.core.toolkit.IdWorker;
 import com.yc.ship.framework.common.pojo.PageResult;
 import com.yc.ship.framework.common.util.object.BeanUtils;
+import com.yc.ship.module.ota.api.OtaDistributorApi;
+import com.yc.ship.module.ota.api.dto.DistributorRespDTO;
 import com.yc.ship.module.product.controller.admin.distributorDiscount.vo.DistributorDiscountPageReqVO;
 import com.yc.ship.module.product.controller.admin.distributorDiscount.vo.DistributorDiscountSaveReqVO;
 import com.yc.ship.module.product.dal.dataobject.distributorDiscount.DistributorDiscountDO;
@@ -27,13 +29,20 @@ public class DistributorDiscountServiceImpl implements DistributorDiscountServic
     @Resource
     private DistributorDiscountMapper distributorDiscountMapper;
 
+    @Resource
+    private OtaDistributorApi otaDistributorApi;
+
     @Override
     public Long createDistributorDiscount(DistributorDiscountSaveReqVO createReqVO) {
         // 插入
+        DistributorRespDTO distributor = otaDistributorApi.getDistributorById(createReqVO.getDistributorId());
         DistributorDiscountDO distributorDiscount = BeanUtils.toBean(createReqVO, DistributorDiscountDO.class);
         distributorDiscount.setId(IdWorker.getId(distributorDiscount));
         distributorDiscount.setAreaId(createReqVO.getAreaId().toString()) ;
+        distributorDiscount.setAreaId(distributor.getName()) ;
         distributorDiscountMapper.insert(distributorDiscount);
+
+
         // 返回
         return distributorDiscount.getId();
     }
@@ -42,9 +51,11 @@ public class DistributorDiscountServiceImpl implements DistributorDiscountServic
     public void updateDistributorDiscount(DistributorDiscountSaveReqVO updateReqVO) {
         // 校验存在
         validateDistributorDiscountExists(updateReqVO.getId());
+        DistributorRespDTO distributor = otaDistributorApi.getDistributorById(updateReqVO.getDistributorId());
         // 更新
         DistributorDiscountDO updateObj = BeanUtils.toBean(updateReqVO, DistributorDiscountDO.class);
         updateObj.setAreaId(updateReqVO.getAreaId().toString()) ;
+        updateObj.setDistributorName(distributor.getName()) ;
         distributorDiscountMapper.updateById(updateObj);
     }
 

ship-module-product/ship-module-product-biz/src/main/java/com/yc/ship/module/product/service/voyagestockdistribute/VoyageStockDistributeServiceImpl.java

@@ -1,38 +1,33 @@
 package com.yc.ship.module.product.service.voyagestockdistribute;
 
+import com.yc.ship.framework.common.pojo.PageResult;
 import com.yc.ship.framework.common.util.collection.CollectionUtils;
+import com.yc.ship.framework.common.util.object.BeanUtils;
 import com.yc.ship.module.ota.api.OtaDistributorApi;
 import com.yc.ship.module.ota.api.dto.DistributorRespDTO;
 import com.yc.ship.module.ota.enums.DistributorTypeEnum;
 import com.yc.ship.module.otc.api.store.StoreApi;
 import com.yc.ship.module.otc.api.store.dto.StoreInfoRespDTO;
-import com.yc.ship.module.otc.api.store.dto.StoreRespDTO;
+import com.yc.ship.module.product.controller.admin.voyagestockdistribute.vo.VoyageStockDistributePageReqVO;
+import com.yc.ship.module.product.controller.admin.voyagestockdistribute.vo.VoyageStockDistributeSaveReqVO;
 import com.yc.ship.module.product.dal.dataobject.voyage.VoyageDO;
 import com.yc.ship.module.product.dal.dataobject.voyagestockdetail.VoyageStockDetailDO;
+import com.yc.ship.module.product.dal.dataobject.voyagestockdistribute.VoyageStockDistributeDO;
 import com.yc.ship.module.product.dal.dataobject.voyagestockdistribute.VoyageStockDistributeLogDO;
 import com.yc.ship.module.product.dal.mysql.voyagestockdistribute.VoyageStockDistributeLogMapper;
-import com.yc.ship.module.product.service.distributorDiscount.DistributorDiscountService;
+import com.yc.ship.module.product.dal.mysql.voyagestockdistribute.VoyageStockDistributeMapper;
 import com.yc.ship.module.product.service.voyage.VoyageService;
 import com.yc.ship.module.product.service.voyagestockdetail.VoyageStockDetailService;
 import org.springframework.stereotype.Service;
-import javax.annotation.Resource;
-import org.springframework.validation.annotation.Validated;
 import org.springframework.transaction.annotation.Transactional;
+import org.springframework.validation.annotation.Validated;
 
-import java.util.*;
+import javax.annotation.Resource;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
 import java.util.stream.Collectors;
 
-import com.yc.ship.module.product.controller.admin.voyagestockdistribute.vo.*;
-import com.yc.ship.module.product.dal.dataobject.voyagestockdistribute.VoyageStockDistributeDO;
-import com.yc.ship.framework.common.pojo.PageResult;
-import com.yc.ship.framework.common.pojo.PageParam;
-import com.yc.ship.framework.common.util.object.BeanUtils;
-
-import com.yc.ship.module.product.dal.mysql.voyagestockdistribute.VoyageStockDistributeMapper;
-
-import static com.yc.ship.framework.common.exception.util.ServiceExceptionUtil.exception;
-import static com.yc.ship.module.product.enums.ErrorCodeConstants.*;
-
 /**
  * 航次库存分配 Service 实现类
  *

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/controller/admin/smsSendconfig/vo/SmsSendconfigQueryRespVO.java

@@ -24,6 +24,10 @@ public class SmsSendconfigQueryRespVO {
     @ExcelProperty("航次名称")
     private String voyageName;
 
+    @Schema(description = "航线名称", example = "李四")
+    @ExcelProperty("航线名称")
+    private String routeName;
+
     @Schema(description = "游船名称", example = "李四")
     @ExcelProperty("游船名称")
     private String shipName;
@@ -91,7 +95,6 @@ public class SmsSendconfigQueryRespVO {
     private String sourceName;
     private String contactName;
     private String mobile;
-    private String routeName;
 
 
     private String sellerId;

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/service/otawindow/impl/OtaOrderServiceImpl.java

@@ -58,7 +58,7 @@ import static com.yc.ship.module.trade.enums.ApiConstants.REDIS_KEY_TRADE_OTA_IN
 @Slf4j
 public class OtaOrderServiceImpl implements OtaOrderService {
     @Resource
-    DistributorMapper distributorMapper;
+    private DistributorMapper distributorMapper;
     @Resource
     private AdminUserApi adminUserApi;
     @Resource

ship-module-trade/ship-module-trade-biz/src/main/java/com/yc/ship/module/trade/service/refund/impl/TradeRefundServiceImpl.java

@@ -2,19 +2,13 @@ package com.yc.ship.module.trade.service.refund.impl;
 
 import cn.hutool.core.bean.BeanUtil;
 import cn.hutool.core.collection.CollUtil;
-import cn.hutool.core.date.DatePattern;
-import cn.hutool.core.date.DateUnit;
 import cn.hutool.core.date.DateUtil;
 import cn.hutool.core.map.MapUtil;
 import cn.hutool.core.util.NumberUtil;
 import cn.hutool.core.util.ObjectUtil;
 import cn.hutool.core.util.StrUtil;
 import cn.hutool.extra.spring.SpringUtil;
-import cn.hutool.json.JSONArray;
-import cn.hutool.json.JSONObject;
-import cn.hutool.json.JSONUtil;
 import com.baomidou.mybatisplus.core.toolkit.IdWorker;
-import com.baomidou.mybatisplus.core.toolkit.StringUtils;
 import com.yc.ship.framework.common.exception.ServiceException;
 import com.yc.ship.framework.common.lang.Asserts;
 import com.yc.ship.framework.common.pojo.CommonResult;
@@ -76,9 +70,9 @@ import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
 import static com.yc.ship.framework.common.exception.util.ServiceExceptionUtil.exception;
-import static com.yc.ship.module.trade.enums.TravelhubDictTypeConstants.NO;
 import static com.yc.ship.module.trade.enums.ApiConstants.*;
 import static com.yc.ship.module.trade.enums.ErrorCodeConstants.*;
+import static com.yc.ship.module.trade.enums.TravelhubDictTypeConstants.NO;
 import static com.yc.ship.module.trade.enums.TravelhubDictTypeConstants.YES;
 import static com.yc.ship.module.trade.service.order.TradeOrderService.UPDATE_ORDER_LOCK;
 

ship-module-trade/ship-module-trade-biz/src/main/resources/mapper/smsSendconfig/SmsSendconfigMapper.xml

@@ -10,17 +10,19 @@
      -->
     <select id="querySendList" resultType="com.yc.ship.module.trade.controller.admin.smsSendconfig.vo.SmsSendconfigQueryRespVO">
         select * from (
-        select t1.*,t2.product_id,t3.product_name,tt2.short_name,t4.order_no,t3.use_date,count(1)
-        num,t4.source_name,t5.contact_name,t5.mobile,t6.`name` as routeName,t7.api_template_id,t7.params templateParams,t8.api_key,t8.api_secret,t8.api_url,t8.signature,t8.code channelCode from
+        select t1.*,t4.group_no groupNo,t66.name voyageName,t77.name shipName,t67.name routeName ,t2.product_id,t3.product_name,tt2.short_name,t4.order_no,t3.use_date,count(1)
+        num,t4.source_name,t5.contact_name,t5.mobile,t7.api_template_id,t7.params templateParams,t8.api_key,t8.api_secret,t8.api_url,t8.signature,t8.code channelCode from
         system_sms_sendconfig t1
         inner join system_sms_product t2 on t1.id = t2.sms_template_id
         inner join trade_detail t3 on t2.product_id = t3.product_id
         inner join product_spu tt2 on t3.product_id = tt2.id
         inner join trade_order t4 on t3.order_id = t4.id
         inner join trade_order_user t5 on t4.id=t5.order_id
-        left join product_route_plan t6 on t4.route_plan_id = t6.id
-        inner join sanxia_system.system_sms_template t7 on t1.sms_template_id=t7.id
-        inner join sanxia_system.system_sms_channel t8 on t8.id = t7.channel_id
+        inner join product_voyage t66 on t66.id = t4.voyage_id
+        inner join resource_route t67 on t66.route_id = t67.id
+        inner join resource_ship t77 on t77.id = t4.ship_id
+        inner join system_sms_template t7 on t1.sms_template_id=t7.id
+        inner join system_sms_channel t8 on t8.id = t7.channel_id
         where t3.use_date <![CDATA[ >= ]]> DATE_SUB(CURDATE(), INTERVAL 0 DAY) and t3.use_date <![CDATA[ <=]]>
         DATE_SUB(CURDATE(), INTERVAL -1 DAY)
         and t3.voucher_status in (1,2)
@@ -35,52 +37,20 @@
             AND t1.send_type = 2
         </if>
         GROUP BY t1.id,t4.id
-        UNION ALL
-        select t1.*,t2.product_id,t3.product_name,tt2.short_name,t4.order_no,t3.use_date,count
-        (1) num,t4.source_name,t5.contact_name,t5.mobile,t6.`name` as routeName,t7.api_template_id,t7.params templateParams,t8.api_key,t8.api_secret,t8.api_url,t8.signature,t8.code channelCode
-        from system_sms_sendconfig t1
-        inner join system_sms_product t2 on t1.id = t2.sms_template_id
-        inner join trade_order t4 on t2.product_id = t4.route_plan_id
-        inner join trade_detail t3 on t3.order_id = t4.id
-        inner join product_spu tt2 on t3.product_id = tt2.id
-        inner join trade_order_user t5 on t4.id=t5.order_id
-        left join product_route_plan t6 on t4.route_plan_id = t6.id
-        inner join sanxia_system.system_sms_template t7 on t1.sms_template_id=t7.id
-        inner join sanxia_system.system_sms_channel t8 on t8.id = t7.channel_id
-        where t3.use_date <![CDATA[ >= ]]> DATE_SUB(CURDATE(), INTERVAL 0 DAY) and t3.use_date <![CDATA[ <= ]]> DATE_SUB(CURDATE(), INTERVAL -1 DAY)
-        and t3.voucher_status in (1,2)
-        and t1.deleted = 0
-        and t2.deleted = 0
-        and t7.deleted = 0
-        and t1.is_use = 1
-        <if test="id != null">
-            AND t1.id = #{id}
-        </if>
-        <if test="type != null and type == 0">
-            AND t1.send_type = 2
-        </if>
-        GROUP BY t1.id,t4.id
         ) m	where  not EXISTS (
             select p1.order_no from system_sms_send_log p1 where status = 1 and m.order_no=p1.order_no and p1.sms_config_id = m.id
         )
     </select>
 
     <select id="querySendLogList" resultType="com.yc.ship.module.trade.controller.admin.smsSendconfig.vo.SmsSendconfigQueryRespVO">
-        select t1.*,t3.product_id,t3.product_name,tt2.short_name,t3.use_date,count(1)
-        num,t2.source_name,t5.contact_name,t6.`name` as routeName from
+        select t1.*,t2.source_name,t5.contact_name from
         system_sms_send_log t1
         inner join trade_order t2 on t1.order_no = t2.order_no
-        inner join trade_detail t3 on t2.id = t3.order_id
-        inner join product_spu tt2 on t3.product_id = tt2.id
         inner join trade_order_user t5 on t2.id=t5.order_id
-        left join product_route_plan t6 on t2.route_plan_id = t6.id
         where 1=1
         <if test="param.smsConfigId != null">
             AND t1.sms_config_id = #{param.smsConfigId}
         </if>
-        <if test="param.travelDate != null and param.travelDate!=''">
-            AND t3.use_date = #{param.travelDate}
-        </if>
         <if test="param.contact != null and param.contact!=''">
             AND (t5.contact_name = #{param.contact} or t1.mobile = #{param.contact})
         </if>